Sign in to Mod The Sims
Replies: 15 (Who?), Viewed: 520 times.
#1
5th Jul 2022 at 6:09 PM
5th Jul 2022 at 6:09 PM
(Scripting) Targeting Sims when Listening for Social Events
Advertisement
#2
6th Jul 2022 at 9:54 AM
6th Jul 2022 at 9:54 AM
Hey Yolksims !
Which Social event? Because it may well just be EA passes it in as a null, but the actor is still actually there.
Because generally speaking, EA tends to do the following:
Meaning, both target/actor has been parsed in.
So I'm wondering it it's maybe the way you're trying to get the actor/target, if you're 100% sure the event you're listening to, sends the right information.
here's how I'd tackle it though:
Which Social event? Because it may well just be EA passes it in as a null, but the actor is still actually there.
Because generally speaking, EA tends to do the following:
Code:
EventTracker.SendEvent(new SocialEvent(EventTypeId.kSocialInteraction, base.Actor, base.Target, this)); EventTracker.SendEvent(new SocialEvent(EventTypeId.kSocialInteraction, base.Target, base.Actor, this));
Meaning, both target/actor has been parsed in.
So I'm wondering it it's maybe the way you're trying to get the actor/target, if you're 100% sure the event you're listening to, sends the right information.
here's how I'd tackle it though:
Code:
public ListenerAction OnSocialization(Event e)
{
SocialEvent socialEvent = e as SocialEvent;
if (socialEvent != null)
{
// Wouldn't 100% recommend this, since we can't always guarantee that "CreatedSim" won't return null or the Simdescription being able to find it.
// Reason for it, is because if a sim isn't in the world (Like a service), then the SimDescription exists, but will return null on CreatedSim.
Sim target = SimDescription.Find(socialEvent.mTargetSimDescription.SimDescriptionId).CreatedSim;
// This is EA's weird naming convention (but sort of makes sense). While it says "Target" this is actually the Actor.
Sim actor = socialEvent.TargetObject as Sim;
// It's always good practise to check for null references 
if (actor != null || target != null)
{
// DO THING HERE
}
else
{
SimpleMessageDialog.Show("Title", "Actor or target were null! Exiting now...");
}
}
return ListenerAction.Keep;
}
#3
6th Jul 2022 at 5:08 PM
Last edited by YolkSims : 7th Jul 2022 at 3:42 AM.
6th Jul 2022 at 5:08 PM
Last edited by YolkSims : 7th Jul 2022 at 3:42 AM.
#4
6th Jul 2022 at 6:48 PM
6th Jul 2022 at 6:48 PM
#5
6th Jul 2022 at 8:50 PM
6th Jul 2022 at 8:50 PM
#6
7th Jul 2022 at 3:41 AM
Last edited by YolkSims : 7th Jul 2022 at 5:31 PM.
7th Jul 2022 at 3:41 AM
Last edited by YolkSims : 7th Jul 2022 at 5:31 PM.
#7
7th Jul 2022 at 12:25 PM
7th Jul 2022 at 12:25 PM
Ohh I totally missed that indeed the base Event class does actually make mTargetObject the target 
Somehow my brain didn't think of that... So ignore my weird SimDescription solution thing! :p
Now, EA did a really odd thing? When passing through the target. It first passes it in as a Sim. Then it passes it in as a minisimdescription and then converts it back to a Simlike.... you made a property for this! What are you doing :p
Anyways, getting to the code....
The main thing to always check is if you're not 100% certain something will always be instantiated. Social Event most likely can be null if EA's code screwed up somewhere, so I'd always do a null check there. I used to absolutely trust my code too (or EA's code rather) to always give me something, but nul references are everywhere. And I mean Everywhere.
So take it from me, null reference check anything you can think ofEven if you're mainly working with 80% of your own code.
Technically we actually don't know if it's 100% the target returning null. We want to know as well if the actor isn't null. That's what I mean with that you can never be certain that it will always be the sim we're looking for, as hickups and weirdness happen and creating a null reference.
So as Consort suggested, null reference the ever-living heck out of everything (to put it mildly) :p
So for debug reasons I'd also do:
That's how I would've debugged it
Secondly, make sure your sims are both in the world. Which they probably are but just mentioning it as the way EA passes in the target can return into a null reference if the sim is still in the relationship tab of your sim, but is a service, or homeless (or in egypt/china/france)
Somehow my brain didn't think of that... So ignore my weird SimDescription solution thing! :pNow, EA did a really odd thing? When passing through the target. It first passes it in as a Sim. Then it passes it in as a minisimdescription and then converts it back to a Sim
like.... you made a property for this! What are you doing :pAnyways, getting to the code....
The main thing to always check is if you're not 100% certain something will always be instantiated. Social Event most likely can be null if EA's code screwed up somewhere, so I'd always do a null check there. I used to absolutely trust my code too (or EA's code rather) to always give me something, but nul references are everywhere. And I mean Everywhere.
So take it from me, null reference check anything you can think of
Even if you're mainly working with 80% of your own code.Technically we actually don't know if it's 100% the target returning null. We want to know as well if the actor isn't null. That's what I mean with that you can never be certain that it will always be the sim we're looking for, as hickups and weirdness happen and creating a null reference.
So as Consort suggested, null reference the ever-living heck out of everything (to put it mildly) :p
So for debug reasons I'd also do:
Code:
private static ListenerAction OnInteraction(Event ev)
{
try
{
SocialEvent SEvent = ev as SocialEvent;
if (SEvent != null && !SEvent.WasRecipient)
{
// Define actor and target sims.
// TargetObject is actually the sim.
Sim Actor = SEvent.mActor as Sim;
Sim Target = SEvent.mTargetObject as Sim;
// Uncomment this if you are done debugging
//if (Actor == null) { return ListenerAction.Keep; }
//if (Target == null) { return ListenerAction.Keep; }
// Comment the Actor, target, boolean (and the if bool true, then return) once you're certain that you've found your null reference.
bool OneReturnedNull = false;
if (Actor == null)
{
SimpleMessageDialog.Show("Title Here", "Actor was null!");
OneReturnedNull = true;
}
if (Target == null)
{
SimpleMessageDialog.Show("Title Here", "Target was null!");
OneReturnedNull = true;
}
// Because we have incomplete data, exit out...
if (OneReturnedNull) { return ListenerAction.Keep; }
// Technically your old Simdescription code can work too, but name is fine as well! you may get some old Localised names though, especially in bridgeport.
string ActorName = Actor.Name;
string TargetName = Target.Name;
Sims3.UI.StyledNotification.Show(new Sims3.UI.StyledNotification.Format("NPCRomance DEBUG: Social Interaction Detected Between:" + ActorName + TargetName, StyledNotification.NotificationStyle.kSimTalking));
}
}
catch (Exception exception)
{
Errorlog.OnError.Exception(exception);
}
return ListenerAction.Keep;
}
That's how I would've debugged it
Secondly, make sure your sims are both in the world. Which they probably are but just mentioning it as the way EA passes in the target can return into a null reference if the sim is still in the relationship tab of your sim, but is a service, or homeless (or in egypt/china/france)
#8
7th Jul 2022 at 3:21 PM
7th Jul 2022 at 3:21 PM
#9
7th Jul 2022 at 5:30 PM
7th Jul 2022 at 5:30 PM
#10
7th Jul 2022 at 6:47 PM
7th Jul 2022 at 6:47 PM
#11
7th Jul 2022 at 9:57 PM
7th Jul 2022 at 9:57 PM
#12
7th Jul 2022 at 10:20 PM
Last edited by Battery : 7th Jul 2022 at 10:35 PM.
7th Jul 2022 at 10:20 PM
Last edited by Battery : 7th Jul 2022 at 10:35 PM.
#13
7th Jul 2022 at 10:30 PM
Last edited by gamefreak130 : 7th Jul 2022 at 10:44 PM.
7th Jul 2022 at 10:30 PM
Last edited by gamefreak130 : 7th Jul 2022 at 10:44 PM.
#14
8th Jul 2022 at 12:59 AM
8th Jul 2022 at 12:59 AM
#15
8th Jul 2022 at 1:49 AM
8th Jul 2022 at 1:49 AM
...We have lift off, guys. It's working.
It's working.
#16
8th Jul 2022 at 2:46 AM
8th Jul 2022 at 2:46 AM
|
|