Sign in to Mod The Sims
Replies: 8 (Who?), Viewed: 1596 times.
Original Poster
#1
7th Jun 2020 at 11:28 PM
7th Jun 2020 at 11:28 PM
Apply buff when sim performs an idle
From what I understand, I think a strategy for doing this could be to add an event listener initialized on world load that listens for the event of a sim doing the idle, and applies my buffs when that happens. It doesn't look like any of the events in the enum Sims3.Gameplay.EventSystem.EventTypeId have anything to do with idles, so instead I'm wondering if I could get the name of the last idle a sim has performed by doing something like this:
IdleManager i = new IdleManager();...and then add the buffs to a sim whenever lastIdleName for that sim is the one I want ("a_pregnancy_idle_rubBelly_x", if you're wondering).
string lastIdleName = i.LastIdle;
So my questions are:
1) Does the above sound like an at least feasible approach to the goal I have? I really don't know the code for this game well enough to tell
2) Does anyone know of any mods that have a similar feature, where a script (for any purpose at all!) is triggered by a sim performing an idle, that I could look inside to see how that was implemented?
Advertisement
#2
8th Jun 2020 at 4:37 AM
Last edited by gamefreak130 : 8th Jun 2020 at 4:51 AM.
8th Jun 2020 at 4:37 AM
Last edited by gamefreak130 : 8th Jun 2020 at 4:51 AM.
Quote: Originally posted by lizcandor
|
Hello! I'm new to script modding (or any modding really, but I do have coding experience - not in C# though), and as my first fully from scratch mod (after reading tutorials and opening up others' mods for a while), I'm trying to insert a script that has a chance to apply some custom buffs every time a sim does the pregnancy idle animation. The way EA made the pregnancy buff work has always annoyed me, every sim shouldn't just be ecstatic about it the whole time, so I figured I'd give fixing it a try. Might be a little much for a first project but I figure disliking EA's handling of pregnancy as much as I do will give me more determination than picking something I have a smaller chip on my shoulder about. From what I understand, I think a strategy for doing this could be to add an event listener initialized on world load that listens for the event of a sim doing the idle, and applies my buffs when that happens. It doesn't look like any of the events in the enum Sims3.Gameplay.EventSystem.EventTypeId have anything to do with idles, so instead I'm wondering if I could get the name of the last idle a sim has performed by doing something like this: IdleManager i = new IdleManager();...and then add the buffs to a sim whenever lastIdleName for that sim is the one I want ("a_pregnancy_idle_rubBelly_x", if you're wondering). So my questions are: 1) Does the above sound like an at least feasible approach to the goal I have? I really don't know the code for this game well enough to tell 2) Does anyone know of any mods that have a similar feature, where a script (for any purpose at all!) is triggered by a sim performing an idle, that I could look inside to see how that was implemented? |
Full disclosure: I've never worked with idles before, nor do I know of any mods that do off the top of my head.
You seem to be on the right track. However, you do not want to simply instantiate a new IdleManager. IdleManagers are meant to be tied to specific sims, and the game already constructs them as needed for this purpose. Instead, what I think you would want to do is something like this:
Code:
using Sims3.Gameplay.Actors;
using Sims3.Gameplay.ActorSystems;
internal static void IdleTest()
{
foreach (Sim sim in Sims3.Gameplay.Queries.GetObjects<Sim>())
{
if (sim.SimDescription.IdleManager is IdleManager idleManager && idleManager.LastIdle == "a_pregnancy_idle_rubBelly_x")
{
sim.BuffManager.AddElement(0xFFFFFFFFFFFFFFFF, Origin.None); // This is the method that adds custom moodlets to a sim, in case you didn't already know
}
}
}
Set this function as the callback of a repeating alarm (created on WorldLoadFinished, as you said), and you should be set.
Original Poster
#3
8th Jun 2020 at 5:37 AM
8th Jun 2020 at 5:37 AM
#4
9th Jun 2020 at 2:15 PM
9th Jun 2020 at 2:15 PM
Quote: Originally posted by lizcandor
| On my first in-game test it turned out my custom buffs aren't getting loaded, though, I can't even assign them with MasterController; so I've got to go back and figure out what's up with that before I can see if the idles thing worked. Thanks for the advice! |
Here are a few helpful links:http://www.simlogical.com/ContentUploadsRemote/uploads/1063/How_Create_Load_Custom_Moodlets_with_Pure_Script_Mod.pdf
http://modthesims.info/showthread.p...5#startcomments
So you basically need to set up some sort of "XML reader" for your buff as well. Which, I can say out of experience, is an annoying one to set up. :p So feel free to ask any questions as well on that if that's not exactly working out!
Original Poster
#5
13th Jun 2020 at 4:30 AM
13th Jun 2020 at 4:30 AM
Original Poster
#6
13th Jun 2020 at 4:01 PM
Last edited by lizcandor : 13th Jun 2020 at 4:20 PM.
13th Jun 2020 at 4:01 PM
Last edited by lizcandor : 13th Jun 2020 at 4:20 PM.
#7
13th Jun 2020 at 7:03 PM
13th Jun 2020 at 7:03 PM
Usually S3PE does indeed show a few "error from these and that dll files" but you might be right given that bit where it says "unable to read beyond the end of the stream". Usually, when that happens there's probably 2 things happening here:
1. Your framework was written in NET3.0 or higher, rather than 2.0 (which the sims is developed in) and therefore the mscorlib not working/compiling correctly with that version.
2. Make sure to double-check step 6 in this tutorial: https://modthesims.info/wiki.php?ti..._Studio_project
Once that's fixed, it should do the trick!
Then it's merely a question whether the code actually works 
. I do want to say though, that having worked on TS3 code actively for a year now, when the notification isn't working, the code above it is probably not working. TS3 doesn't really have much of a debug method except for writing out the exception error in a notification or modal. :/
Do let us know how it goes though!
1. Your framework was written in NET3.0 or higher, rather than 2.0 (which the sims is developed in) and therefore the mscorlib not working/compiling correctly with that version.
2. Make sure to double-check step 6 in this tutorial: https://modthesims.info/wiki.php?ti..._Studio_project
Once that's fixed, it should do the trick!
Then it's merely a question whether the code actually works . I do want to say though, that having worked on TS3 code actively for a year now, when the notification isn't working, the code above it is probably not working. TS3 doesn't really have much of a debug method except for writing out the exception error in a notification or modal. :/ Do let us know how it goes though!
Original Poster
#8
21st Jun 2020 at 1:38 AM
21st Jun 2020 at 1:38 AM
Buffs work!
I read through that tutorial (thanks Lyralei!) and a couple others again, did those 2 checks, and then discovered I was making an embarrassingly dumb mistake. But for the record, for the sake of future modding newbies who may be the same kind of fool as me and need it pointed out: dragging and dropping DLLs into S3PE is not the same as going through the whole series of steps in the Building The Package section of the Pure Scripting Modding tutorial, and things will not work if you do that
After being reminded of the instructions, the S3SA file in my package looked normal in s3pe, and the package actually showed up in the list of mods on starting the game, which it didn't before. My custom buffs still weren't loading at first, which is what I was trying to understand for the last while and finally solved today: it seems like there must have been a localization issue, although I don't know what it was. For testing the package, I'd only made an English STBL, because I'd assumed my game wouldn't need the others; but eventually there was nothing else left I could check, so I used the STBL duplicator to make strings for all the other languages it supports just to see if that would change anything. It did, the buffs work just fine now.
The other part of my initial plan, assigning the buffs based on the occurrence of a specific idle, hasn't worked yet. I'm not giving up on that idea yet, but as a workaround for now I'm just having the callback function to a repeating alarm on each pregnant sim check if the pregnancy is visible and then roll to see if either or both buffs should be applied based on traits. Slightly less fun, but it works and the effect is basically the same.
Thanks!
Original Poster
#9
23rd Jun 2020 at 9:20 AM
Last edited by lizcandor : 23rd Jun 2020 at 10:48 AM.
23rd Jun 2020 at 9:20 AM
Last edited by lizcandor : 23rd Jun 2020 at 10:48 AM.
|
|